chore: resolve the issue with active menu items when two or more pages start with the same URL (GCOM-1482) #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 706629e The changes in this PR will be included in the next version bump. This PR includes changesets to release 81 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paales
reviewed
Sep 16, 2024
| @@ -42,7 +42,7 @@ export function DesktopNavItem(props: DesktopNavItemLinkProps | DesktopNavItemBu | |||
|
|
|||
| const { href, children, sx = [], ...linkProps } = props | |||
|
|
|||
| const active = router.asPath.startsWith((href ?? '').toString()) | |||
| const active = router.asPath === (href ?? '').toString() | |||
There was a problem hiding this comment.
The idea was that if a child is selected that the parent would be selected as well, so that breaks with this, any suggestions?
There was a problem hiding this comment.
@paales see my latest changes 🙂
Now it activates the parent and only the menu item that exactly matches the router.asPath.
https://github.com/graphcommerce-org/graphcommerce/pull/2369/files
carlocarels90
force-pushed
the
fix/active-menu-item
branch
from
9e0cec3 to
bab99dc
Compare
carlocarels90
changed the title
…ustomized for a project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCOM-1482