Sticky AddToCart Component on Product Page (GCOM-1194) #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e81ffd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
mikekeehnen
reviewed
Aug 25, 2023
packages/magento-product/components/ProductPageWrapper/ProductPageWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/magento-product/components/StickyAddToCart/StickyAddToCart.tsx
Outdated
Show resolved
Hide resolved
packages/magento-product/components/StickyAddToCart/StickyAddToCart.tsx
Outdated
Show resolved
Hide resolved
packages/magento-product/components/StickyAddToCart/StickyAddToCart.tsx
Outdated
Show resolved
Hide resolved
paales
changed the title
|
paales
changed the title
paales
reviewed
Sep 5, 2023
| export const component = 'ProductPageAddToCartActionsRow' | ||
| export const exported = | ||
| '@graphcommerce/magento-product/components/ProductPage/ProductPageAddToCartRow' | ||
| export const ifConfig: IfConfig = 'enableStickyAddToCart' |
There was a problem hiding this comment.
This plugin is self-referencing. So the plugin is targeting the current package. Shouldn't we make this a simple if statement somewhere? @carlocarels90 / @mikekeehnen.
There was a problem hiding this comment.
We could, but we could also make it a separate package right @paales? This would make it a plug and play solution
There was a problem hiding this comment.
@mikekeehnen if we do this, we don't need the config file I guess? Because it will apply only when you add this package to your project?
…ify this component with plugins
…roductPageWrapper
…tate without using numbers for switchPoint
… its parent component to trigger the visibility of StickAddToCart
…ced compatibility with configurable products.
…o we can add products to cart within the StickyAddToCart
…AddProductsToCartForm to prevent issues with the addtocart
…yAddToCart option is enabled
…oductsToCartAction fragment
…eatePortal to calculate if the button is in viewport
…utside the Box component.
carlocarels90
force-pushed
the
feature/GCOM-1194
branch
from
48a44a5 to
e81ffd5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example product with an StickyAddToCart component:
https://graphcommerce-git-feature-gcom-1194-graphcommerce.vercel.app/p/talented-bffs-gc-1026-sock