Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data fetching app dir #1932

Open
wants to merge 41 commits into
base: canary
Choose a base branch
from
Open

Data fetching app dir #1932

wants to merge 41 commits into from

Conversation

paales
Copy link
Member

@paales paales commented May 12, 2023

No description provided.

paales added 30 commits April 13, 2023 14:04
@paales
Setting up the homepage as an RSC
cd1e5f1
@paales
Remove the pages directory
ad69059
@paales
Patch mui material with use client
bdae421
@paales
Use live endpoint for nwo
50822ae
@paales
Added storeconfig
56c3424
@paales
App dir stuff
3f71b2e
@paales
Reduce logging
60bab06
@paales
Work in progress to use enhanceStaticProps
62dbf9c
@paales
Cleanup
0e85747
@paales
Further rework of server handling
e3fca14
@paales
Cleanup
a84b3ca
@paales
Further refactors
5af05d5
@paales
Remove graphqlSsrClient from lib
67b7018
@paales
Cleanup
08e43a8
@paales
wip
fd93d27
@paales
Wip
95958d6
@paales
Wip
017fc57
@paales
Merge branch 'canary' into feature/lib-graphql
8d2f61b 
# Conflicts:
#	examples/magento-graphcms/pages/404.tsx
#	examples/magento-graphcms/pages/search/index.tsx
#	packages/graphql-mesh/package.json
#	packages/graphql/package.json
#	packages/magento-category/package.json
#	packages/magento-search/package.json
#	packages/magento-store/package.json
#	packages/next-ui/package.json
#	packagesDev/eslint-config/package.json
#	yarn.lock
@paales
update packages
0c9b4ac
@paales
Upgade mui
c56115e
@paales
Installed correct react-is version
9f9e2dc
@paales
Move to InferGetStaticProps
4036b84
@paales
Fix ts errors
db1e38b
@paales
Extract layout props to own function
ff8ae2d
@paales
Move to a parallel loader
b7ca237
@paales
build
001f9ed
@paales
Further work
902ffc7
@paales
Wip
41cb10b
@paales
Fix build issues
05f4d74
@paales
Merge branch 'feature/app-dir' into feature/lib-graphql
238dd92 
# Conflicts:
#	examples/magento-graphcms/lib/graphql/graphqlSsrClient.ts
#	examples/magento-graphcms/package.json
#	examples/magento-graphcms/pages/404.tsx
#	examples/magento-graphcms/pages/[...url].tsx
#	examples/magento-graphcms/pages/account/addresses/add.tsx
#	examples/magento-graphcms/pages/account/addresses/edit.tsx
#	examples/magento-graphcms/pages/account/addresses/index.tsx
#	examples/magento-graphcms/pages/account/authentication/index.tsx
#	examples/magento-graphcms/pages/account/contact/index.tsx
#	examples/magento-graphcms/pages/account/forgot-password.tsx
#	examples/magento-graphcms/pages/account/index.tsx
#	examples/magento-graphcms/pages/account/name/index.tsx
#	examples/magento-graphcms/pages/account/orders/index.tsx
#	examples/magento-graphcms/pages/account/orders/view.tsx
#	examples/magento-graphcms/pages/account/reviews/add.tsx
#	examples/magento-graphcms/pages/account/reviews/index.tsx
#	examples/magento-graphcms/pages/account/signin.tsx
#	examples/magento-graphcms/pages/blog/[url].tsx
#	examples/magento-graphcms/pages/blog/page/[page].tsx
#	examples/magento-graphcms/pages/blog/tagged/[url].tsx
#	examples/magento-graphcms/pages/c/[...url].tsx
#	examples/magento-graphcms/pages/cart.tsx
#	examples/magento-graphcms/pages/checkout/added.tsx
#	examples/magento-graphcms/pages/checkout/customer/addresses/edit.tsx
#	examples/magento-graphcms/pages/checkout/edit/billing-address.tsx
#	examples/magento-graphcms/pages/checkout/index.tsx
#	examples/magento-graphcms/pages/checkout/payment.tsx
#	examples/magento-graphcms/pages/checkout/success.tsx
#	examples/magento-graphcms/pages/checkout/terms/[url].tsx
#	examples/magento-graphcms/pages/customer/account/createPassword/index.tsx
#	examples/magento-graphcms/pages/index.tsx
#	examples/magento-graphcms/pages/modal/[...url].tsx
#	examples/magento-graphcms/pages/newsletter/index.tsx
#	examples/magento-graphcms/pages/p/[url].tsx
#	examples/magento-graphcms/pages/products-sitemap.xml/index.tsx
#	examples/magento-graphcms/pages/search/[...url].tsx
#	examples/magento-graphcms/pages/search/index.tsx
#	examples/magento-graphcms/pages/service/[[...url]].tsx
#	examples/magento-graphcms/pages/switch-stores.tsx
#	examples/magento-graphcms/pages/test/[[...url]].tsx
#	examples/magento-graphcms/pages/test/buttons.tsx
#	examples/magento-graphcms/pages/test/icons.tsx
#	examples/magento-graphcms/pages/test/minimal-page-shell-subheader/[[...url]].tsx
#	examples/magento-graphcms/pages/test/sheet.tsx
#	examples/magento-graphcms/pages/test/slider.tsx
#	examples/magento-graphcms/pages/test/typography.tsx
#	examples/magento-graphcms/pages/wishlist/index.tsx
#	packages/framer-next-pages/example/package.json
#	packages/framer-next-pages/example/pages/multi-stack/[...url].tsx
#	packages/framer-scroller/example/package.json
#	packages/graphcms-ui/plugins/HygraphGraphqlProvider.tsx
#	packages/graphql-mesh/package.json
#	packages/graphql/components/GraphQLProvider/GraphQLProvider.tsx
#	packages/image/example/package.json
#	packages/magento-product/components/ProductFiltersPro/index.ts
#	packages/magento-product/components/index.ts
#	packages/magento-store/index.ts
#	packages/magento-store/plugins/MagentoStoreGraphqlProvider.tsx
#	packages/next-ui/hooks/useStorefrontConfig.ts
#	packages/next-ui/package.json
#	packagesDev/eslint-config/package.json
#	yarn.lock
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ddc7ddb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graphcommerce ❌ Failed (Inspect) May 23, 2023 10:50am

@paales
Copy link
Member Author

paales commented Jun 23, 2023

I've communicated on the slack chat earlier:

The current appDir implementation is highly unstable and requires:

  • Patching @types/react
  • Running alpha branches of typescript
  • Running canary branches of nextjs

It is very slow to build at the moment (about 4x as slow). Experiencing constant OOM errors, running into obscure internal react errors etc.

We’re relying heavily on Apollo Client, they are one of the first libraries that take RSC seriously (apollo-client-nextjs), but it still is very incomplete at the moment.

I think that marking the app dir as stable was more of a point to communicate to developers: We need feedback, we’re not getting it while it is in beta, since nobody is using it. Library maintainers: It’s your turn, this API is what you are going to get.

We do however got streaming rendering working, which is exciting!

As for the future migration story: We’ll either keep supporting the pages directory for the years to come, or we’ll provide a smooth migration path in the future.

@paales paales added the stale label Nov 8, 2023
@paales paales changed the base branch from feature/lib-graphql to canary June 1, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paales