Refactor data fetching #1920
Open
Refactor data fetching #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # examples/magento-graphcms/pages/404.tsx # examples/magento-graphcms/pages/search/index.tsx # packages/graphql-mesh/package.json # packages/graphql/package.json # packages/magento-category/package.json # packages/magento-search/package.json # packages/magento-store/package.json # packages/next-ui/package.json # packagesDev/eslint-config/package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the data fetching store to achieve a better abstraction.
Introduce
enhanceStaticProps(original),enhanceServiceSideProps(original),enhanceStaticProps(original)functions which wrap the nextjs' defaultgetStaticProps,getServerSidePropsandgetStaticPathsfunctions respectively.This allows us to do quite a few things:
The
enhance*methods leverage node.js' AsyncLocalStorage functionality to wrap all function calls in astorefrontContext. Which allows users to usestorefrontConfig()without passing any arguments.This means that we do not need to initialize the
graphqlSsrClient()andgraphqlSharedClient()with any arguments. Which in turn allows us to abstract away these methods tographqlQuery(query, options)andgraphqlQueryPassToClient(query, options)and move them to the library (because the extensibility is handled by plugins now #1915)Other notable changes:
Created a split in packages for shared components and server only components where most packages will have a secondary
/serverexport. e.g.:@graphcommerce/magento-product/serverfor methods are are meant to be only run on the server. (we might useimport 'server-only'in these packages if nextjs supports it for the pages directory)Removed
legacyProductRouteconfiguration + removed thepages/product/*files + removed the ProductPage query. We're now fully migrated to the recentp/[url]route.