Fix issue where the discount value displayed in the cart gets the tax subtracted twice when displaying prices excluding tax. #1824
Conversation
… subtracted twice when displaying prices excluding tax.
🦋 Changeset detectedLatest commit: 13ba96a The changes in this PR will be included in the next version bump. This PR includes changesets to release 66 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This issue happens when you have both Magento and GC configured to display prices excluding taxes. I am not entirely certain whether the prices incl/excl tax setting for GC is expected to always match the Magento setting, or whether you are supposed to be able to use a different setting for GC than you have for Magento. I suppose it makes sense to be able to vary this, for instance if you have a single Magento install with multiple GC frontends for B2B and B2C. If the Magento and GC settings are not required to match then this PR will not actually fix the issue, it will only move the problem to installs where Magento is configured for prices including tax and GC is configured to display prices excluding tax. To fix the issue in both situations I think you would need to have additional information from Magento, for instance if you had both the discount including tax and the discount excluding tax then you can choose which you need. If you could find out which setting Magento is using that would also be helpful in determining whether or not GC needs to subtract VAT. |
|
Not sure what to do with this? |
paales
changed the title
|
|
|
… subtracted twice when displaying prices excluding tax.