Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context-http1): fix disconnectAll #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefan-guggisberg
Copy link
Contributor

There's a bug in the Http1 disconnectAll implementation. https://github.com/grantila/fetch-h2/blob/master/lib/context-http1.ts#L141 is never executed because the waiting array is truncated on the preceding line.

This PR fixes this by copying the waiting array.

@stefan-guggisberg
Copy link
Contributor Author

@grantila I am still struggling with dangling http1 connections despite calling disconnectAll() and stumbled over this issue while debugging. Fixing it doesn't solve my dangling connections problem but I thought it's worth reporting anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant