Add ability to disable cookie processing altogether by setting cookie… #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Jar to undefined in context
ghost
reviewed
Jul 13, 2023
| @@ -181,11 +181,14 @@ describe( `context (${version} over ${proto.replace( ":", "" )})`, ( ) => | |||
| userAgent: "foobar", | |||
| } ); | |||
|
|
|||
| await fetch( `${proto}//localhost:${port}/set-cookie`, { | |||
| const response1 = await fetch( `${proto}//localhost:${port}/set-cookie`, { | |||
There was a problem hiding this comment.
[minor]: It's batter to avoid numbers in a variable name. It seems like a code smell. If you realised that you need more then one response, so just describe in the name of these responses what you expect.
| @@ -41,10 +41,10 @@ export interface ServerOptions | |||
| export abstract class Server | |||
| { | |||
| public port: number | null = null; | |||
| public receivedCookies: Array<string> = new Array<string>(); | |||
There was a problem hiding this comment.
[minor]: It is not a good idea to use constructors as types.
- Some constructors, such as Object, Function, or Array, are very broad and do not provide much type safety or information. Using them as types can make the code less clear and more prone to bugs.
- TypeScript has built-in types for primitive values, such as number, string, boolean, etc. Using constructors like Number, String, or Boolean as types can lead to unexpected behavior and type errors.
Suggested change
| public receivedCookies: Array<string> = new Array<string>(); | |
| public receivedCookies: string[] = []; |
| @@ -310,11 +314,11 @@ export class ServerHttp1 extends TypedServer< HttpServer | HttpsServer > | |||
| } | |||
|
|
|||
| export async function makeServer( opts: ServerOptions = { } ) | |||
| : Promise< { server: Server; port: number | null; } > | |||
| : Promise< { server: Server; port: number | null; receivedCookies: Array<string> } > | |||
There was a problem hiding this comment.
[minor]: As i described before use constructors as types is not a good idea.
Suggested change
| : Promise< { server: Server; port: number | null; receivedCookies: Array<string> } > | |
| : Promise< { server: Server; port: number | null; receivedCookies: string[] } > |
| @@ -360,11 +363,11 @@ export class ServerHttp2 extends TypedServer< Http2Server > | |||
| } | |||
|
|
|||
| export async function makeServer( opts: ServerOptions = { } ) | |||
| : Promise< { server: Server; port: number | null; } > | |||
| : Promise< { server: Server; port: number | null; receivedCookies: Array<string> } > | |||
There was a problem hiding this comment.
[minor]: As i described before use constructors as types is not a good idea.
Suggested change
| : Promise< { server: Server; port: number | null; receivedCookies: Array<string> } > | |
| : Promise< { server: Server; port: number | null; receivedCookies: string[] } > |
| @@ -82,7 +82,7 @@ export class Context | |||
| private _userAgent: string | PerOrigin< string >; | |||
| private _overwriteUserAgent: boolean | PerOrigin< boolean >; | |||
| private _accept: string | PerOrigin< string >; | |||
| private _cookieJar: CookieJar; | |||
| private _cookieJar: undefined | CookieJar; | |||
There was a problem hiding this comment.
[minor]: since you need to use the same type in another place, so I would suggest that you make this an alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Jar to undefined in context
Fixes: #109