New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: https connect timeout #100

Open

stefan-guggisberg wants to merge 3 commits into grantila:master from stefan-guggisberg:https-connect-timeout

Contributor

stefan-guggisberg commented Apr 5, 2020

fixes TLS connection timeout handling.

Example:

  const { context } = require('fetch-h2');
  const { fetch } = context({ session: { timeout: 500 } });
  fetch('https://example.com:81/').catch{(err) => console.log(err));
  // prints "connect timed out after 500 ms"

partial (https only) fix for #99

stefan-guggisberg added 3 commits

April 5, 2020 16:01


          fix: https connect timeout

a316623


          fix: handle race condition between timeout and error

922a977


          trivial: formatting

5492a8b

Contributor Author

stefan-guggisberg commented Apr 10, 2020

@grantila Could you please have a look at this PR and #99 ? It's a serious problem for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet