feat(compiler): Improve exhaustive warning for lists #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair,
phated and
alex-snezhko
as code owners
ospencer
approved these changes
Dec 28, 2024
Maybe? I really hate the untypeast stuff, but it would be nice to use the formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr improves the way we print exhaustiveness warnings for list constructors an example can be seen below:
As a side note, and without looking into this I wonder if it would make sense or if we should at least open an issue to move from a custom printer here to somehow using the formatter, we do have a function to convert from the typedtree nodes back into the parsetree nodes which we should be able to pipe into the formatter this would maintain a consistent
Closes: #2217