fix(compiler): Prevent impossible string error from pattern matching #2218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when we had a non exhaustive pattern including a string such as:
we would hit an impossible error upon further investigation i noticed that we convert the constructors from typetree nodes back into ParseTree nodes and that we did not add the quotes back onto the string when we do this, I corrected that and added two small regression tests.
Closes: #2216