feat(stdlib): Add Bytes.setChar and Bytes.getChar
#2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair,
jozanza,
phated,
alex-snezhko and
marcusroberts
as code owners
Co-authored-by: Oscar Spencer <[email protected]>
ospencer
approved these changes
Jan 2, 2025
ospencer
changed the title
Bytes.setChar and Bytes.getChar, along with utf8 refactors.Bytes.setChar and Bytes.getChar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr was originally only meant to add
Bytes.setCharandBytes.getCharbut I wanted it to share the utf8 impl with the string library, One thing led to another and I added a newUtf8library into the runtime.The
Utf8module houses all of the shared low level utf8 logic for encoding and decoding I also refactored the runtime and stdlib to make use of these sharedHelpers which removed a lot of duplicate code and I think should be enough to close out #684As this pr got a little off track I am happy to make this pr just a refactor and move the
setCharandgetCharchanges to a separate pr. A small note on the function themselves, compared to the other set and get methodscharsare slightly different as we need to account for the range of byte sizes this is going to makeBuffer.setCharslightly more annoying when I get around to that.