Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stdlib): Optimize String.trim #1965

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

spotandjake
Copy link
Member

This optimizes String.trim by avoiding the double allocation of a new string after each separate string. Now we only allocate a new string once weve trimmed both sides.

I think this optimization can also close: #982 even though we still do two seperate iterations combing them would likely lead to unmaintainable code with a minimal performance increase.

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the energy to debate about a single loop 😛

@phated phated added this pull request to the merge queue Jan 26, 2024
Merged via the queue into grain-lang:main with commit f0f1f87 Jan 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stdlib: Avoid double iteration on String.trim
2 participants