Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(stdlib): Leverage Infinity keyword in Regex module #1959

Merged
merged 1 commit into from
Jan 20, 2024
Merged

chore(stdlib): Leverage Infinity keyword in Regex module #1959

merged 1 commit into from
Jan 20, 2024

Conversation

spotandjake
Copy link
Member

This pr just changes the Regex library from using Float32.toNumber(Float32.infinity)) to Infinity, which means we can drop the uneccessary dependency

@spotandjake spotandjake self-assigned this Jan 3, 2024
@phated phated changed the title chore(stdlib): Switch Regex lib from using Float32.infinity to Infinity chore(stdlib): Leverage Infinity keyword in Regex module Jan 20, 2024
@phated phated added this pull request to the merge queue Jan 20, 2024
Merged via the queue into grain-lang:main with commit d5e6468 Jan 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@ospencer ospencer Awaiting requested review from ospencer ospencer is a code owner

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

Assignees

@spotandjake spotandjake

Labels
cleanup stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spotandjake @phated