Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib)!: Replace Float32 arithmatic/comparison functions with operators #1954

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

spotandjake
Copy link
Member

This pr switches Float32 from using functions to operators

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NaNf and Infinityf are hilarious.

We should remember to remove any let NaN and let Infinity bindings throughout the stdlib.

@phated phated added this pull request to the merge queue Jan 7, 2024
@phated phated removed this pull request from the merge queue due to a manual request Jan 7, 2024
@phated phated changed the title chore(stdlib): Switch Float32 functions to operators chore(stdlib)!: Switch Float32 functions to operators Jan 7, 2024
@phated
Copy link
Member

phated commented Jan 7, 2024

@spotandjake please remember to flag breaking changes as breaking. I almost missed this one.

@phated phated added this pull request to the merge queue Jan 7, 2024
@phated phated removed this pull request from the merge queue due to a manual request Jan 7, 2024
@phated phated changed the title chore(stdlib)!: Switch Float32 functions to operators feat(stdlib)!: Replace Float32 arithmatic/comparison functions with operators Jan 7, 2024
@phated phated added this pull request to the merge queue Jan 7, 2024
Merged via the queue into grain-lang:main with commit 52cc15a Jan 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants