Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graindoc)!: Allow @since and @returns once per export #1946

Merged
merged 4 commits into from
Jan 27, 2024

Conversation

spotandjake
Copy link
Member

This pr makes it so that you can only have one occurance of @since and @returns per provided export.

Closes: #787

@spotandjake spotandjake self-assigned this Jan 2, 2024
@spotandjake spotandjake force-pushed the spotandjake-graindoc-singleattr branch from bf7a067 to 9b7312b Compare January 3, 2024 01:19
@spotandjake spotandjake added the graindoc Issues related to Graindoc label Jan 16, 2024
Copy link
Member

@alex-snezhko alex-snezhko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice

@spotandjake spotandjake requested a review from peblair as a code owner January 24, 2024 19:25
@spotandjake
Copy link
Member Author

Added tests for those.

@spotandjake spotandjake force-pushed the spotandjake-graindoc-singleattr branch from c385c26 to db22073 Compare January 24, 2024 20:38
@phated phated added this pull request to the merge queue Jan 27, 2024
Merged via the queue into grain-lang:main with commit ad977aa Jan 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graindoc Issues related to Graindoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graindoc: Raise exception on multiple attributes that only allow one
3 participants