Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(compiler): Make Ast_helper locs non optional #1934

Merged
merged 7 commits into from
Dec 30, 2023
Merged

chore(compiler): Make Ast_helper locs non optional #1934

merged 7 commits into from
Dec 30, 2023

Conversation

spotandjake
Copy link
Member

This pr makes locatons on ast nodes not optional.

Question should we also refactor the anf_helper nodes to have non optional locs in this pr or should we do that in a seperate pr.

Closes: #1106

@spotandjake spotandjake self-assigned this Dec 7, 2023
@ospencer ospencer changed the title core(compiler): Make Ast_helper locs non optional chore(compiler): Make Ast_helper locs non optional Dec 11, 2023
ospencer
ospencer approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I agree that we should do anf_helper in another PR.

phated
phated approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thanks!

@phated phated added this pull request to the merge queue Dec 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 30, 2023
@spotandjake spotandjake added this pull request to the merge queue Dec 30, 2023
Merged via the queue into grain-lang:main with commit a8cc3cd Dec 30, 2023
13 checks passed
@spotandjake spotandjake deleted the spotandjake-ast_locs branch December 30, 2023 02:18
@spotandjake spotandjake mentioned this pull request Aug 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer approved these changes

@phated phated phated approved these changes

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

Assignees

@spotandjake spotandjake

Labels
cleanup compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler: Ast_helper locations should not be optional
3 participants
@spotandjake @phated @ospencer