feat(stdlib): Add fromArray to Queue module
#1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts and
jozanza
as code owners
jozanza
approved these changes
Dec 5, 2023
|
This is simple and makes sense, though I'm curious from @alex-snezhko if it makes sense to allocate a larger underlying array since the moment you add a new element, it'll have to resize itself. |
|
That sounds like a good idea, maybe make the size double the array length |
|
Done |
phated
reviewed
Dec 29, 2023
phated
reviewed
Dec 29, 2023
|
Applied those suggestions |
phated
reviewed
Dec 31, 2023
|
@spotandjake please resolve the conflicts 🙏 |
spotandjake
force-pushed
the
spotandjake-queue-fromArray
branch
from
5436bee to
a1369a7
Compare
Done |
phated
approved these changes
Dec 31, 2023
phated
changed the title
fromArray to QueuefromArray to Queue module
phated
changed the title
fromArray to Queue modulefromArray to Queue module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
fromArrayto theQueuemodule, helping to bring it more inline with the other stdlib data structures.