Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails-156: Update to Grails Redis Plugin to be compatible with Grails 7.x.x #158

Merged
merged 16 commits into from
Oct 18, 2024

Conversation

amondel2
Copy link
Contributor

Update to JDK 17
Update to Grails 7.0.0-SNAPSHOT
Update to Groovy 4
Update gradle to 8.10.2
Update to use Gradle.settings for dependencies
Update to use DEVELOCITY and new Grails Publishing (Please verify I did this correctly)
Fixed some ignored test
Refactored the example program to create item in a transactional service
Refactored the example program to use LocalDate over Date

@amondel2
Copy link
Contributor Author

@jamesfredley Can you please review

build.gradle Outdated Show resolved Hide resolved
@jamesfredley jamesfredley self-requested a review October 17, 2024 13:05
build.gradle Outdated Show resolved Hide resolved
Copy link
Contributor

@jamesfredley jamesfredley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. Just a few changes in comments.

* grails-156: Update H2 version to latest

* grails-156: Fix Comments from Code Review
@amondel2 amondel2 requested a review from jamesfredley October 18, 2024 13:31
@jamesfredley jamesfredley merged commit 80f6c14 into grails:5.0.x Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants