Refactor Grafana Vale style so it can be easily packaged #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags aren't necessarily made to the HEAD of the version branch. The documentation to be published is always on the HEAD of the release branch. Because the workflow now uses regular expressions in Bash, inputs must now use Extended Regular Expression syntax. Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
The new directory structure matches the format explained in errata-ai/vale#925. Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
force-pushed
the
jdb/2024-11-vale-releases
branch
from
48ad08a to
7618ba3
Compare
|
💻 Deploy preview deleted. |
Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
force-pushed
the
jdb/2024-11-vale-releases
branch
from
b59b301 to
07381b8
Compare
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jdbaldry
requested review from
chri2547,
clayton-cornell,
knylander-grafana and
a team
as code owners
clayton-cornell
approved these changes
Dec 6, 2024
Co-authored-by: Clayton Cornell <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
chri2547
approved these changes
Dec 16, 2024
robbymilo
approved these changes
Dec 20, 2024
…ases Signed-off-by: Jack Baldry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new directory structure matches the format explained in errata-ai/vale#925.
Tests in the
vale/fixturesdirectory aren't working but I can look to fix them up later. I'd prefer to see regular packaged releases for the community.The diff is really large because of the moving around of directories.
A review can focus on: