Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Headings.yml with SSO, OAuth, Terraform #456

Merged
merged 8 commits into from
Feb 14, 2024

Conversation

mgyongyosi
Copy link
Contributor

@mgyongyosi mgyongyosi requested a review from jdbaldry as a code owner February 5, 2024 15:37
@mgyongyosi mgyongyosi changed the title Update Headings.yml.with SSO, OAuth, Terraform Update Headings.yml with SSO, OAuth, Terraform Feb 5, 2024
@mgyongyosi mgyongyosi marked this pull request as draft February 5, 2024 16:00
@mgyongyosi
Copy link
Contributor Author

Moved back to Draft, because I'm gonna add other exceptions probably.

@jdbaldry
Copy link
Member

jdbaldry commented Feb 6, 2024

Thanks for the contribution. I'll take a look when you move this PR out of draft :)

@jdbaldry
Copy link
Member

jdbaldry commented Feb 9, 2024

Hey bud, any updates on this? Have you found additional terms to add to this PR?

@mgyongyosi
Copy link
Contributor Author

Hey, previously I forgot to link the other PR which we are still working on: https://github.com/grafana/website/pull/17940

I'm gonna reopen this PR when we know all of the exceptions we need for that PR! ;)

@mgyongyosi mgyongyosi marked this pull request as ready for review February 14, 2024 17:18
@mgyongyosi
Copy link
Contributor Author

@jdbaldry This is ready for review! 🚀

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I've moved the exceptions into our ruleset and regenerated the dictionary from the wordlist.

All the changes except one look perfectly good to me.

vale/Grafana/Headings.yml Outdated Show resolved Hide resolved
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks again!

@mgyongyosi mgyongyosi merged commit bfd7b69 into main Feb 14, 2024
6 checks passed
@mgyongyosi mgyongyosi deleted the add-heading-exceptions branch February 14, 2024 17:42
@jdbaldry
Copy link
Member

After https://github.com/grafana/writers-toolkit/actions/runs/7905213104/job/21577302560 completes, you can rerun CI on https://github.com/grafana/website/pull/17940 and Vale should be a lot more quiet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants