-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Headings.yml with SSO, OAuth, Terraform #456
Conversation
Moved back to Draft, because I'm gonna add other exceptions probably. |
Thanks for the contribution. I'll take a look when you move this PR out of draft :) |
Hey bud, any updates on this? Have you found additional terms to add to this PR? |
Hey, previously I forgot to link the other PR which we are still working on: https://github.com/grafana/website/pull/17940 I'm gonna reopen this PR when we know all of the exceptions we need for that PR! ;) |
@jdbaldry This is ready for review! 🚀 |
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I've moved the exceptions into our ruleset and regenerated the dictionary from the wordlist.
All the changes except one look perfectly good to me.
Co-authored-by: Jack Baldry <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks again!
After https://github.com/grafana/writers-toolkit/actions/runs/7905213104/job/21577302560 completes, you can rerun CI on https://github.com/grafana/website/pull/17940 and Vale should be a lot more quiet :) |
I'd like to use those in https://github.com/grafana/website/pull/17940