Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vale rule for README usage #393

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Add Vale rule for README usage #393

merged 4 commits into from
Dec 4, 2023

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Nov 30, 2023 •
edited
Loading

For readme or Readme it will suggest README.

For readme.md or Readme.md it will suggest README.md.

@jdbaldry jdbaldry requested a review from imatwawana November 30, 2023 11:01
github-actions[bot]
github-actions bot reviewed Nov 30, 2023
View reviewed changes
vale/Grafana/README.yml Outdated Show resolved Hide resolved
@jdbaldry @github-actions
Prettier
0dad3e4 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jdbaldry jdbaldry mentioned this pull request Nov 30, 2023
Merged
imatwawana
imatwawana approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I'm just wondering if this means Vale will suggest both README.md and README?

Base automatically changed from ihm/291123-add-readme to main December 4, 2023 14:02
@jdbaldry
Copy link
Member Author

jdbaldry commented Dec 4, 2023

For readme or Readme it will suggest README.

For readme.md or Readme.md it will suggest README.md.

(updated description with this too).

@jdbaldry jdbaldry merged commit 5f90d0c into main Dec 4, 2023
5 checks passed
@jdbaldry jdbaldry deleted the jdb/2023-11-README branch December 4, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@imatwawana imatwawana imatwawana approved these changes

@josmperez josmperez Awaiting requested review from josmperez

@knylander-grafana knylander-grafana Awaiting requested review from knylander-grafana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdbaldry @imatwawana