Add collapse shortcode use cases #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatwawana
added
the
type/docs
imatwawana
requested review from
jdbaldry,
josmperez and
knylander-grafana
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
osg-grafana
reviewed
Oct 11, 2023
| The following example is for a deprecated store and shouldn't be used for new Loki deployments: | ||
|
|
||
| {{</* collapse title="boltdb-shipper" */>}} | ||
| Also known as “boltdb-shipper” during development (and is still the schema store name). |
There was a problem hiding this comment.
Suggested change
| Also known as “boltdb-shipper” during development (and is still the schema store name). | |
| Also known as _boltdb-shipper_ during development (and is still the schema store name). |
osg-grafana
reviewed
Oct 11, 2023
osg-grafana
reviewed
Oct 11, 2023
osg-grafana
approved these changes
Oct 11, 2023
jdbaldry
reviewed
Oct 11, 2023
JStickler
approved these changes
Oct 11, 2023
Co-authored-by: Jack Baldry <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ursula Kallio <[email protected]>
|
Overall readability score: 60.07 (🔴 -0.03)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
imatwawana
commented
Oct 18, 2023
imatwawana
commented
Oct 18, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constrains use cases for the
collapseshortcode to deprecations and configuration options per the Oct 5 style roundtable meeting. Also adds guidance re lead-in sentences and titles.