Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix G302 gosec issues #10378

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix G302 gosec issues #10378

merged 1 commit into from
Jan 9, 2025

Conversation

dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented Jan 8, 2025

What this PR does

G302: Expect file permissions to be 0600 or less

Changes here are mostly noop except for a very niche mimirtool command for converting cortex config, which at this point probably nobody uses

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Dimitar Dimitrov <[email protected]>
@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner January 8, 2025 14:44
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 works for me

@dimitarvdimitrov dimitarvdimitrov merged commit d68b6ad into main Jan 9, 2025
29 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/fix-G302 branch January 9, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants