[1/2] Implement the --local-execution mode for k6 cloud run #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
requested review from
mstoykov and
olegbespalov
and removed request for
a team
9 tasks
joanlopez
reviewed
Aug 21, 2024
joanlopez
reviewed
Aug 21, 2024
This commits aligns the handling of the --no-usage-report option in the context of the k6 cloud run command with the following agreed upon behavior: * k6 cloud run --no-usage-report should ignore the flag, and make sure we don't send the report. * k6 cloud run --local-execution --no-usage-report should take the flag in consideration, and act accordingly.
codebien
reviewed
Aug 29, 2024
Co-authored-by: Ivan <[email protected]>
olegbespalov
reviewed
Sep 2, 2024
olegbespalov
added
the
documentation-needed
5 tasks
oleiade
changed the title
olegbespalov
previously approved these changes
Sep 9, 2024
joanlopez
previously approved these changes
Sep 9, 2024
Co-authored-by: Oleg Bespalov <[email protected]>
oleiade
dismissed stale reviews from joanlopez and olegbespalov
via
e4dec3f
olegbespalov
previously approved these changes
Sep 10, 2024
joanlopez
reviewed
Sep 10, 2024
olegbespalov
approved these changes
Sep 10, 2024
joanlopez
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds support for a new
--local-executionflag to the k6 cloud run command. Using it, users can run their test script or archive on their local machine while streaming the results to the cloud.In the context of this PR, the goal is to reproduce the behavior of the
k6 run -o cloudbehavior; we will add support for archive upload, logs, and trace forwarding in future PRs.Considerations and open questions
k6 cloud runflags are now only allowed/relevant in conjunction with--local-execution. However, after brainstorming, we couldn't find a satisfactory name, that wouldn't feel weird and confusing (I'm looking at youk6 cloud run-locally.--lingerand--no-usage-reportoptions from thek6 runcommand and made them available/functional only when--local-executionis passed. Do we consider this approach satisfactory?getConfigfunction to enforce the output to be set tocloud. This is the most straightforward way we found to do this. If you have a better idea, please feel free to suggest 🙇🏻Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
ref #3818
ref #3282