Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] PoC for native distributed execution #2438

Closed
wants to merge 28 commits into from
Closed

[WIP] PoC for native distributed execution #2438

wants to merge 28 commits into from

Conversation

na--
Copy link
Member

@na-- na-- commented Mar 11, 2022

This is a proof of concept for the refactoring we need to do to do a simple version of #140. The tests are not fixed yet, and there are quite a lot of rough edges, but it works 🎉

na-- added 28 commits March 7, 2022 08:43
@na--
Simplify requirements calculation in k6 inspect
0a21f8f
@na--
Refactor cmd/ to get rid of most direct os package access
a30ce02 
This makes everything much more easily testable!
@na--
Test that --logformat is deprecated but still works
2fef1d7
@na--
Start with a colorful log if stderr is TTY, but also respect NO_COLOR
3f035f1 
This will ensure we have the same behavior as previous k6 version there's an error before setupLoggers() is executed, e.g. when parsing a wrong CLI flag. However, we will now also respect NO_COLOR and K6_NO_COLOR and disable it when they are specified.
@na--
Do not output k6 banner and test description when --quiet is enabled
b73890e
@na--
Do not output cloud login token to stdout when --quiet is enabled
63c678d
@na--
Refactor test loading by moving it to a new helper function
a45511e
@na--
Refactor abort signal handling into a separate helper
de3ae30
@na--
Move K6_TYPE / --type / -t out of the globalFlags to RuntimeOptions
516fc9b 
This actually also fixes a minor bug where the CLI flag was available in `k6 run` and `k6 inspect`, but it wasn't available in `k6 cloud` and `k6 archive`.
@na--
Simplify createOutputs()
07cc65a
@na--
Refactor cmd.rootCommand to support easy integration tests
20f689c
@na--
Fix --log-output=file support for relative paths and add a test
dd5736a
@na--
Rename and document better the cmd/inspect.go internals
9923347
@na--
Remove js.Bundle.IsExecutable() because it's not needed anymore
e4241ca
@na--
Move some output init calls away from the Engine
207ef83
@na--
Flatten some long functions in cmd/ and enable splitting them apart
f82b364
@na--
Move Output management out of the Engine
f83e784
@na--
Move the metrics package out of lib/
98911d0
@na--
Refactor the Engine to actually use the metrics registry
adc4d9f 
This is a prerequisite for solving other issues like always evaluating thresholds correctly, and as a side-benefit, it also allows us to validate them in the init context, before the test has started.
@na--
Fix the bug of thresholds not working for unused metrics
e5d8c32
@na--
Fix submetric matching bug when nonexistent keys are specified
a3138b1
@na--
Pass BuiltinMetrics via ExecState, emit vus and vus_max by ExecScheduler
559f4c5 
This allows us to slowly deconstruct and split apart the Engine. It also clears the way for us to have test suites, where every test has a separate pool of VUs and its own ExecutionScheduler.
@na--
Add an integration test for custom metrics and thresholds
954e7b5
@na--
Move the Engine data crunching logic in a new component under metrics/
2476cfc
@na--
Completely remove the Engine 🎉
8850e35
@na--
Move core/local/ExecutionScheduler to execution/Scheduler
a17f256
@na--
Use openhistogram/circonusllhist for TrendSinks
38f9b99
@na--
Add support for native distributed execution and metrics
60237cc
@na-- na-- modified the milestone: v0.38.0 Mar 11, 2022
@na-- na-- added this to the v0.39.0 milestone Mar 16, 2022
@na-- na-- force-pushed the cleanup-7 branch 3 times, most recently from 591a0fe to f06d6f0 Compare March 18, 2022 13:18
@na-- na-- mentioned this pull request Mar 22, 2022
Merged
@na-- na-- force-pushed the cleanup-7 branch 3 times, most recently from 58fca82 to 8276246 Compare March 29, 2022 09:13
Base automatically changed from cleanup-7 to master March 29, 2022 13:26
@na-- na-- mentioned this pull request Apr 26, 2022
Closed
@na-- na-- mentioned this pull request Jun 8, 2022
Open
@shibrady shibrady mentioned this pull request Jun 8, 2022
Closed
@na-- na-- mentioned this pull request Jun 9, 2022
Closed
@na-- na-- modified the milestones: v0.39.0, v0.40.0 Jun 13, 2022
@na-- na-- mentioned this pull request Jun 15, 2022
Closed
@elfranne elfranne mentioned this pull request Jul 11, 2022
Open
@na-- na-- removed this from the v0.40.0 milestone Jul 11, 2022
@na-- na-- mentioned this pull request Nov 17, 2022
Open
@na-- na-- mentioned this pull request Dec 9, 2022
Draft
@na--
Copy link
Member Author

na-- commented Dec 9, 2022

This PR has become ultra-stale, so I'm closing it as it is, to preserve its historical state.

Over the last several days, I've polished and greatly expanded some of the PoC changes here in multiple PRs on top of the current master. A few with tests and bugfixes like #2795 and #2798 (and other smaller ones) were already merged. The rest form a chain of ready to review (and hopefully merge soon 🤞 ) PRs that refactor big parts of the k6 core into a framework that is much nicer to work with and build upon: #2800 -> #2803 -> #2807 -> #2810 -> #2812 -> #2813 -> #2815

The final 2 very WIP commits here were also rebased on the latest master (and ⬆️ ) changes and expanded just a little bit, but they are still pretty raw and unpolished, so they were pushed in a new WIP PR: #2816

@na-- na-- closed this Dec 9, 2022
@na-- na-- deleted the wip-more-refactoring branch December 9, 2022 09:04
This was referenced Jul 20, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@na--