[tempo-distributed] Remove duplicated ingester podLabels #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimKev2
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
SimKev2
changed the title
SimKev2
force-pushed
the
simkev2/podLabelFix
branch
from
310e6ba
to
3136fde
Compare
zalegrala
approved these changes
Nov 25, 2024
|
Hey @SimKev2 could you please resolve the conflicts ? Thanks! |
Signed-off-by: Kevin Simons <[email protected]>
Signed-off-by: Kevin Simons <[email protected]>
Signed-off-by: Kevin Simons <[email protected]>
SimKev2
force-pushed
the
simkev2/podLabelFix
branch
from
a427201
to
1c6c035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3237
Ran into an issue when trying to add
podLabelsinto our deploy of tempo.Tracking back to the rendering here, it seems like the
.Values.ingester.podLabelsare duplicated between the statefulset definition and the_helpers.tplfunction : https://github.com/grafana/helm-charts/blob/main/charts/tempo-distributed/templates/ingester/_helpers-ingester.tpl#L172-L174