-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo-distributed] Define default affinity for compactor #3422
base: main
Are you sure you want to change the base?
[tempo-distributed] Define default affinity for compactor #3422
Conversation
fb7366f
to
d4cd07f
Compare
Hi @mapno ! :) I have pushed an update with the Let me know what you think 😉 Thanks! |
Hi @froblesmartin. I think putting a disclaimer in the README should be enough for this change. A minor version update seems ok. Thanks for the PR! |
Signed-off-by: Francisco Robles Martín <[email protected]>
d4cd07f
to
5c18d07
Compare
@mapno done 😉 bumped a minor version and added some lines in the README 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
As it is not even defined as null as an example, I guess it was just totally forgotten. 😄 But it is available to be used at
helm-charts/charts/tempo-distributed/templates/compactor/deployment-compactor.yaml
Lines 114 to 116 in 51db949
I am defining the same affinities as everywhere else, also the same as in loki-distributed for the compactor.
Please, let me know if everything is alright or if I should change something.