Skip to content

Commit

Permalink
Merge pull request #3057 from hobbsh/unique-cluster-label-loki
Browse files Browse the repository at this point in the history
[loki-distributed] set unique cluster_label for loki-distributed memberlist
  • Loading branch information
Sheikh-Abubaker authored Nov 15, 2024
2 parents d9107be + da83f37 commit d822475
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/loki-distributed/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: loki-distributed
description: Helm chart for Grafana Loki in microservices mode
type: application
appVersion: 2.9.10
version: 0.79.4
version: 0.80.0
home: https://grafana.github.io/helm-charts
sources:
- https://github.com/grafana/loki
Expand Down
6 changes: 5 additions & 1 deletion charts/loki-distributed/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# loki-distributed

![Version: 0.79.4](https://img.shields.io/badge/Version-0.79.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.9.10](https://img.shields.io/badge/AppVersion-2.9.10-informational?style=flat-square)
![Version: 0.80.0](https://img.shields.io/badge/Version-0.80.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.9.10](https://img.shields.io/badge/AppVersion-2.9.10-informational?style=flat-square)

Helm chart for Grafana Loki in microservices mode

Expand All @@ -24,6 +24,10 @@ helm repo add grafana https://grafana.github.io/helm-charts

Major version upgrades listed here indicate that there is an incompatible breaking change needing manual actions.

### To 0.80.0

Upgrading to chart 0.80.0 will set the memberlist cluster_label config option. During rollout your cluster will temporarilly be split into two memberlist clusters until all components are rolled out. This will interrupt reads and writes. This config option is set to prevent cross talk between Loki and other memberlist clusters.

### From 0.78.x to 0.79.0
Removed the hardcoded, deprecated `boltdb.shipper.compactor.working-directory` flag in the Compactor Deployment template, so that it can be set with `.Values.compactor.extraArgs` and the `compactor.working-directory` flag if necessary.

Expand Down
4 changes: 4 additions & 0 deletions charts/loki-distributed/README.md.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ helm repo add grafana https://grafana.github.io/helm-charts

Major version upgrades listed here indicate that there is an incompatible breaking change needing manual actions.

### To 0.80.0

Upgrading to chart 0.80.0 will set the memberlist cluster_label config option. During rollout your cluster will temporarilly be split into two memberlist clusters until all components are rolled out. This will interrupt reads and writes. This config option is set to prevent cross talk between Loki and other memberlist clusters.

### From 0.78.x to 0.79.0
Removed the hardcoded, deprecated `boltdb.shipper.compactor.working-directory` flag in the Compactor Deployment template, so that it can be set with `.Values.compactor.extraArgs` and the `compactor.working-directory` flag if necessary.

Expand Down
1 change: 1 addition & 0 deletions charts/loki-distributed/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ loki:
store: memberlist
memberlist:
cluster_label: "{{ .Release.Name }}.{{ .Release.Namespace }}"
join_members:
- {{ include "loki.fullname" . }}-memberlist
Expand Down

0 comments on commit d822475

Please sign in to comment.