Set instance ID from pod:container and let setting metadata from annotations #1391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the way the instance ID is composed. This means that instanceID is not assured to be globally unique anymore, but the service_name/namespace/instance tuple. This required changing some internals about how we use the
svc.ID
andsvc.UID
types.Also, lets overriding the service metadata by means of user-selected pod labels.
This PR also seems to fix (or at leas decrease) a memory leak that was present in the Store, by changing the way that containers are grouped by owner and deleted.
TODO: