Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Beyla cache internal metrics to use attributes #1382

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

mariomac
Copy link
Contributor

This will simplify some queries and dashboarding

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (dad9dab) to head (50ccb67).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/kubecache/instrument/imetrics.go 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
- Coverage   81.07%   80.99%   -0.08%     
==========================================
  Files         147      147              
  Lines       14770    14745      -25     
==========================================
- Hits        11975    11943      -32     
- Misses       2210     2217       +7     
  Partials      585      585              
Flag Coverage Δ
integration-test 58.73% <0.00%> (+0.10%) ⬆️
k8s-integration-test 59.80% <88.23%> (-0.11%) ⬇️
oats-test 34.18% <0.00%> (+0.07%) ⬆️
unittests 51.89% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mariomac mariomac marked this pull request as ready for review November 19, 2024 15:25
@mariomac mariomac merged commit 99e7f0f into grafana:main Nov 19, 2024
13 checks passed
@mariomac mariomac deleted the rename-internal-metrics branch November 19, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants