Skip to content

Commit

Permalink
fix misleading comment
Browse files Browse the repository at this point in the history
  • Loading branch information
mariomac committed Nov 27, 2024
1 parent 72c6c6d commit 152d49d
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pkg/internal/kube/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,10 @@ var DefaultMetadataSources = MetadataSources{
ServiceNamespaceAnnotations: []string{
"resource.opentelemetry.io/service.namespace",
},
// default by empty. If the OTEL operator Instrumentation CRD sets useLabelsForResourceAttributes: true,
// empty by default. If a user sets useLabelsForResourceAttributes: true it its OTEL operator, also
// the values below should be populated so:
// - `app.kubernetes.io/name` becomes `service.name`
// - `app.kubernetes.io/version` becomes `service.version`
// - `app.kubernetes.io/part-of` becomes `service.namespace`
// - `app.kubernetes.io/instance` becomes `service.instance.id`
// - `app.kubernetes.io/part-of` becomes `service.namespace`
ServiceNameLabels: nil,
ServiceNamespaceLabels: nil,
}
Expand Down

0 comments on commit 152d49d

Please sign in to comment.