Use upstream stlrs crate
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This mainly just means we have to clone a little more and cast things
between f32 and f64, because the released version of stl-rs doesn't
allow us to take ownership of the various components and doesn't include
f64 compatibility.
Note that this still currently points towards the main git branch for
stl-rust, but at least all the incorporated changes are more likely to
be merged sooner or later!
Unfortunately this results in some benchmark regressions, probably due
to the extra clones and having to convert to/from f32 :(
```
Running benches/vic_elec.rs (target/release/deps/vic_elec-36a0fad3091799a8)
vic_elec time: [28.569 ms 28.591 ms 28.619 ms]
change: [+11.550% +11.750% +11.918%] (p = 0.00 < 0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) high mild
5 (5.00%) high severe
```
sd2k
force-pushed
the
stl-rs-released-compatibility
branch
from
2e73958 to
a0c4bad
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
stlrs will have its own implementation of MSTL in v0.3.0 which means less for this crate to maintain. Benchmarks show it runs pretty much identically to the augurs implementation which is nice. The only downside is the f64 -> f32 conversion required before calling the stlrs APIs but that would be required anyway if we want to avoid any forks.
sd2k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly just means we have to cast things between f32 and f64, because the released version of stl-rs doesn't include f64 compatibility (see ankane/stl-rust#6 and ankane/stl-rust#2).
Note that this still currently points towards a fork of stl-rs, but at least all the incorporated changes are more likely to be merged and released soon, at which point this can be updated to use a non-git dependency.
Unfortunately this results in some benchmark regressions compared to using a fork, probably due to the extra clones and having to convert to/from f32 :(