Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add power transformation logic to forecaster transforms #185
Add power transformation logic to forecaster transforms #185
Changes from 2 commits
4b0d100
0bcedb4
4408e2d
834cf61
a6e8d56
6ae5e95
d922b47
8a61a50
4e43431
5f7f8cc
c89d42e
efc36c1
c3a908d
ebfd3c7
8d4d2d7
214bee9
3d5ea97
f5fa4c9
4460c58
0d92206
b164377
7f4a719
eeecd63
f8ae9b0
2d7c724
434ab52
75bf73a
934e431
6e82356
0a8ff4e
6b7644c
575242d
2e431ae
c1c9303
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add domain validation to prevent invalid computations.
The function should validate that
y * lambda + 1.0
is positive when computing the power function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edwardcqian should we be doing this? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we will reasonably get non-pos value here but doesn't hurt.