fix: correctly set holiday feature to 1 for all holiday dates #175
Conversation
Prior to this commit, the holiday feature was only set to 1 for the first occurrence of a holiday date. This meant that the holiday effect was only applied to predictions for that single datetime in the dataframe, rather than all dates in the dataframe that were on the holidays. This commit fixes that by iterating over all dates in the dataframe that are on the holiday, and setting the holiday feature to 1.0 for those dates.
WalkthroughThe changes primarily focus on the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)crates/augurs-prophet/src/prophet/prep.rs (1)
The implementation now properly sets the holiday feature to 1.0 for all matching dates by using the Let's verify the fix by checking for any other holiday-related code: ✅ Verification successfulLet me gather more context about the holiday feature implementation to ensure the fix is comprehensive. Let me try a different approach to examine the holiday feature implementation. The holiday feature implementation is correctly handling all occurrences After examining the complete implementation, the fix is properly implemented and consistent with the rest of the codebase. The code:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Search for holiday-related code to ensure consistent handling.
# Test: Search for holiday-related code. Expect: Only this occurrence of holiday feature setting.
rg -A 5 'holiday.*feature'
Length of output: 2565 Script: #!/bin/bash
# Search for the complete implementation of make_holiday_features
ast-grep --pattern 'fn make_holiday_features($$$) {
$$$
}'
Length of output: 62 Script: #!/bin/bash
# Search for the complete implementation using ripgrep with context
rg -U "fn make_holiday_features" -A 50 "crates/augurs-prophet/src/prophet/prep.rs"
Length of output: 2450 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying augurs with
|
| Latest commit: |
07d3d73
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f451e7d6.augurs.pages.dev |
| Branch Preview URL: | https://prophet-fix-holidays-with-su.augurs.pages.dev |
Prior to this commit, the holiday feature was only set to 1 for the
first occurrence of a holiday date. This meant that the holiday
effect was only applied to predictions for that single datetime
in the dataframe, rather than all dates in the dataframe that
were on the holidays.
This commit fixes that by iterating over all dates in the dataframe
that are on the holiday, and setting the holiday feature to 1.0 for
those dates.
Summary by CodeRabbit
New Features
Documentation