-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecated slack files.upload is replaced with new slack bot APIs #242
base: main
Are you sure you want to change the base?
Conversation
As mentioned here https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay I mad changes to use new APIs now with backward compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
It's not commonplace in Grafana to reach into environment variables directly, so we'll need to find an alternative to this, some options:
- Don't make it configurable, just use the new API and be done with it.
- Make it configurable via Grafana global config level, pass the config down
- Make it configurable on the integration level
…I is default and one and only
Thank you for your time. I have used the new API and removed the old one completely. |
ENHANCEMENT
Mentioned in some
issues
#235As mentioned here https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay I mad changes to use new APIs now with backward compatibility for
Slack
.