-
Notifications
You must be signed in to change notification settings - Fork 434
WIP Introduce composite-build-logic sample #1037
base: master
Are you sure you want to change the base?
Conversation
@eskatos Can you also include in this sample how to setup the testing environment for the plugin as well? If someone were to take this sample straight from the repository it would be awesome if the testing mechanisms were already in place. |
With two included builds for build logic: - gradle/shared - gradle/plugins And a variety of dependencies including both the outer build and the plugins included build using the shared included build Signed-off-by: Paul Merlin <[email protected]>
dbe63c5
to
a44b938
Compare
Signed-off-by: Paul Merlin <[email protected]>
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?! Does this actually work!? I've been looking to try do do this sort of thing for quite a while now.
Okay. Will try this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine from Gradle perspective. From my testing it seems IDEA can't import it though. I'll get back to this soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's really good information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah I do this in my kotlin multiplatform (prior to their recent huge refactor of the MPP plugins) composite projects. I haven't added native yet, so that might be while I don't have any issues with IDEA imports using this technique.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mean to start an actual review. Ignore this (auto-approving without actual review).
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah I do this in my kotlin multiplatform (prior to their recent huge refactor of the MPP plugins) composite projects. I haven't added native yet, so that might be while I don't have any issues with IDEA imports using this technique.
Still requires a work around for https://github.com/gradle/gradle-native/issues/522, see the
settings.gradle.kts
file.