chore(vars-create-input): Adding Create Factories to Input types #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks, this feature looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
it's the
createfactories guy again!Since we've been busy using the create factories we've added a while back, we noticed that we must have forgotten to apply the same factories to input types doh
This makes it hard using the
createfactories/initializer very hard since input types are kinda necessary to be covered when yourVars/Inputs go beyond simple value types.This PR fixes that previous oversight and adds
createfactories to Input types.I've added a unit test as well for completeness, but please let mw know if there are any questions on this!
Thanks