#feat: Add value or absent option

[LiLatee]

Hey! 👋
I've been lacking the option to send a value if it exists and not send any value (neither null) if not present.

EDIT: Converted to DRAFT, because it's not working yet.

[knaeckeKami]

Why do you need a separate class for that?
Adding a new subtype to a sealed class is a breaking change.

And there are no new states - a value is either present or absent. we don't need a separate type for this, this could be a static method or factory, couldn't it?

factory Value.ofNullabe(T? t) {
   if(t == null} { 
      return Value.absent();
   }
   return Value.present(t);
}

[LiLatee]

Adding a new subtype to a sealed class is a breaking change.

Yes, I've noticed that 😅
So you are right, it's better to just add a factory. Seems to work fine in my case 👌 Idk why I complicated it so much 😞
Thanks!

[knaeckeKami]

please remove the $ from the test strings.

I like static test names better if possible, dynamic ones make filtering by test name harder, and the test names generally become weird:

[knaeckeKami]

Also breaks IntellIj "rerun test" feature

[LiLatee]

For sure ${Value.ofNullable} should not be there. I forgot to check how it looks like in logs.
But personally I like to use e.g. $AbsentValue, because it's very helpful when refactoring the code. You don't have to remember about every place in the code where you have just a string with the class name.
But I changed all the names to static ones 👌

[knaeckeKami]

can this be const?

[LiLatee]

It should be... My mistake. I am used to having a lint prefer_const_constructors 😅 Thanks 🙏

[knaeckeKami]

yeah I know, gql_pedantic should be modernized at some point ;)

[knaeckeKami]

final nit:

Thinking about it, I think .ofNullable is not a great name for the behavior "present if not null, absent otherwise".

What about Value.absentWhenNull() ? of can you think of something more descriptive?

[LiLatee]

Regarding the name I was thinking about Value.valueOrAbsent, but I have to admit that your absentWhenNull looks better 👌 Changed

[knaeckeKami]

thanks! lgtm