chore(vars-builder-bugfix): Fixing nullables and type overrides for vars create factories #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caffeineflo
force-pushed
the
fh/vars-factories
branch
from
d36d243 to
e7b9260
Compare
caffeineflo
force-pushed
the
fh/vars-factories
branch
2 times, most recently
from
bcf551a to
0c9501f
Compare
caffeineflo
force-pushed
the
fh/vars-factories
branch
from
173b59c to
843ea4c
Compare
|
LGTM! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @knaeckeKami!
Unfortunately I found a bug in my previous commit for the vars create factories 🙈
Nullables were still required and types that were in the typeOverrides, were called with the
toBuilder()function causing the compiler to fail for these files.🙈 🙈 🙈 🤦 🤦 🤦 🙈🙈🙈
I fixed it on this branch and hoping we can merge this as a new bugfix version. Sorry for the initial oversight.
As for Ferry: Happy to open a PR making this new bugfix version a dependency if that helps you at all!
Thanks,
Florian!