Merge branch 'master' of github.com:gql-dart/gql into release

gql-dart · Nov 12, 2023 · 4707ca2 · 4707ca2
2 parents bba9c7a + df4f529
commit 4707ca2
Show file tree

Hide file tree

Showing 17 changed files with 117 additions and 42 deletions.
diff --git a/...nd_to_end_test_tristate/lib/fragments/__generated__/fragment_with_scalar_var.var.gql.dart b/...nd_to_end_test_tristate/lib/fragments/__generated__/fragment_with_scalar_var.var.gql.dart
diff --git a/..._to_end_test_tristate/lib/fragments/__generated__/fragment_with_scalar_var.var.gql.g.dart b/..._to_end_test_tristate/lib/fragments/__generated__/fragment_with_scalar_var.var.gql.g.dart
diff --git a/...gen/end_to_end_test_tristate/lib/fragments/__generated__/hero_with_fragments.var.gql.dart b/...gen/end_to_end_test_tristate/lib/fragments/__generated__/hero_with_fragments.var.gql.dart
diff --git a/...n/end_to_end_test_tristate/lib/fragments/__generated__/hero_with_fragments.var.gql.g.dart b/...n/end_to_end_test_tristate/lib/fragments/__generated__/hero_with_fragments.var.gql.g.dart
diff --git a/codegen/end_to_end_test_tristate/lib/fragments/__generated__/multiple_fragments.var.gql.dart b/codegen/end_to_end_test_tristate/lib/fragments/__generated__/multiple_fragments.var.gql.dart
diff --git a/...en/end_to_end_test_tristate/lib/fragments/__generated__/multiple_fragments.var.gql.g.dart b/...en/end_to_end_test_tristate/lib/fragments/__generated__/multiple_fragments.var.gql.g.dart
diff --git a/codegen/end_to_end_test_tristate/lib/graphql/__generated__/schema.schema.gql.dart b/codegen/end_to_end_test_tristate/lib/graphql/__generated__/schema.schema.gql.dart
diff --git a/codegen/end_to_end_test_tristate/lib/graphql/__generated__/schema.schema.gql.g.dart b/codegen/end_to_end_test_tristate/lib/graphql/__generated__/schema.schema.gql.g.dart
diff --git a/codegen/end_to_end_test_tristate/lib/scalars/__generated__/review_with_date.var.gql.dart b/codegen/end_to_end_test_tristate/lib/scalars/__generated__/review_with_date.var.gql.dart
diff --git a/codegen/end_to_end_test_tristate/lib/scalars/__generated__/review_with_date.var.gql.g.dart b/codegen/end_to_end_test_tristate/lib/scalars/__generated__/review_with_date.var.gql.g.dart
diff --git a/codegen/end_to_end_test_tristate/lib/variables/__generated__/create_review.var.gql.dart b/codegen/end_to_end_test_tristate/lib/variables/__generated__/create_review.var.gql.dart
diff --git a/codegen/end_to_end_test_tristate/lib/variables/__generated__/create_review.var.gql.g.dart b/codegen/end_to_end_test_tristate/lib/variables/__generated__/create_review.var.gql.g.dart
diff --git a/codegen/end_to_end_test_tristate/test/schema/scalars_test.dart b/codegen/end_to_end_test_tristate/test/schema/scalars_test.dart
@@ -63,7 +63,7 @@ void main() {
         BuiltList([DateTime.fromMillisecondsSinceEpoch(1591892597000)]),
       ));
     test('correctly overrides scalars in input types', () {
-      expect((input.seenOn! as PresentValue<BuiltList>).value!.first,
+      expect((input.seenOn as PresentValue<BuiltList>).value!.first,
           TypeMatcher<DateTime>());
     });
 
@@ -86,7 +86,7 @@ void main() {
     );
 
     test('correctly overrides scalars in variable types', () {
-      expect((vars.createdAt! as PresentValue).value, TypeMatcher<DateTime>());
+      expect((vars.createdAt as PresentValue).value, TypeMatcher<DateTime>());
     });
 
     test('can be serialized and deserialized with custom serializer', () {

diff --git a/codegen/gql_code_builder/CHANGELOG.md b/codegen/gql_code_builder/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.9.1+1
+
+- fix generating the `Value` wrappers as nullable
+
 ## 0.9.0
 
 - add TriStateValueConfig option in order to wrap nullable fields in input types in a `Value` class in order distinguish between three cases:

diff --git a/codegen/gql_code_builder/lib/src/common.dart b/codegen/gql_code_builder/lib/src/common.dart
@@ -213,7 +213,7 @@ Method buildOptionalGetter({
 
   final optionalGetter = baseGetter.rebuild((b) => b
     ..returns = TypeReference((b2) => b2
-      ..isNullable = true
+      ..isNullable = false
       ..url = valueTypeUrl
       ..symbol = valueTypeSymbol
       ..types.add((baseGetter.returns as TypeReference)