Add confirmation on container remove #61
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Guillaume,
here I am with the implementation of the confirmation dialog for the remove action.
I introduced a reusable component in a separate file, inheriting from Gnome Shell base ModalDialog, and added a new property to the actions dictionary, indicating whether an action needs the user to confirm for its execution.
I also started worrying a bit about the hierarchy of source files at this point, but haven't had any change yet. I thought that maybe it could be reorganized by placing UI components in a dedicated folder, like this:
I tested it against gnome-shell 3.36.3 on Ubuntu 20.04 and 3.28.4 on Ubuntu 18.04, and haven't experienced any particular issue.
As always, consider the implementation as a draft, and please feel free to propose changes if you don't like something, you know I don't want to overcome your voice on structure decisions for the project!
Have a good weekend,
Alessandro