Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki updates #15

Merged
merged 31 commits into from
Nov 7, 2024
Merged

Wiki updates #15

merged 31 commits into from
Nov 7, 2024

Conversation

PierreDillard
Copy link
Contributor

Response to Feedback

Thank you for your detailed feedback.

Glossary tab / Keywords Cloud

  • The glossary tab doesn't show up in expert mode, is that expected?

    • The glossary tab is currently not displaying in either "expert" or "beginner" mode. This feature is still under development and will be implemented in a future update.
  • Dark mode styling missing

    • Dark mode styling has been addressed for collapses, keywords cloud, top navigation, and toggle button. Some updates may not be visible on dev.wiki.gpac.io as modifications were made to /overrides files outside of /doc.
  • Is this compatible with tags?

    • Yes, it's compatible with tags. We could potentially use tags for glossary pages to make them easier to find.

Back to top

  • Dark mode styling missing
    • Dark mode styling has been implemented for this feature.

Beginner / Expert mode

  • Motivation for this change

    • The focus has been primarily on the "howtos" section. The intention is to allow new users to quickly access essential information.
    • Detailed categorization will be discussed further with Jean.
  • Expert mode switch location

    • The expert mode switch location has been changed to be next to the dark mode icon, although this isn't visible on dev.wiki.gpac.io due to /overrides modifications.
  • Content tagging and related switch

    • A new document, "content-tagging-system.md", has been created at the project root to detail the tagging system's functionality.
    • The default behavior has been rectified to "expert" mode, showing everything by default.
  • Bug on /Filters/avmix page

    • This has been documented in content-tagging-system.md. It's a formatting issue when there's a code block in the markdown. The solution is to add a line break between the code block and the following line. Some pages have been fixed, but others still need attention.
  • Search feature issue

    • A tooltip has been added to inform users that switching to expert mode is better for searching.

Collapsible content

  • Dark mode styling

    • Dark mode styling has been implemented.
  • Default collapsed state

    • The decision to collapse everything by default was made for better readability. However, this functionality could be limited to specific sections if it's too disruptive.
  • Spacing issue

    • The spacing issue between the title and the permalink button has been fixed.
  • Safari desktop issue

    • The issue couldn't be reproduced. More information about specific pages where this occurs would be helpful.

Switch (TOC/NAV) on the left

  • Reason for change

    • This change was primarily made to accommodate the keyword cloud.
  • User understanding

    • The icon has been changed and a tooltip added to inform users about the ability to switch between TOC and nav. These changes are not yet visible on dev.wiki.gpac.io due to needed /overrides modifications.

Git related feedback

  • Force push and file modifications
    • The git issues have been resolved by starting with a new branch.

@PierreDillard
Copy link
Contributor Author

PierreDillard commented Sep 23, 2024

Main Updates:

  • Restored the Table of Contents (TOC) on the right side of the page.
    image

  • All collapsed menus are now opened by default.

  • Added a new "Settings" menu in the header to allow users to personalize their experience:

    • Expert/Beginner option: By default, the experience is set to "Expert."
    • Collapse menus: Menus are expanded by default.
    • Dark mode settings.

Capture d’écran du 2024-09-23 15-36-16

  • In the Filters and MP4 box :
    • In Expert mode, all filter options are visible.
    • In Beginner mode, only the "basic" options are displayed.

@PierreDillard
Copy link
Contributor Author

Hey @nlsdvl,

I hope you're doing well! When you have a moment, could you please review the updates in this PR? I've restored the Table of Contents, adjusted the menu settings, and added a few customization options. Any feedback would be greatly appreciated !

PierreDillard and others added 8 commits September 24, 2024 11:38
- Resolved issues with the collapse icons on the left sidebar.
- Improved the navigation behavior related to icon collapsing.
- Changed the modal behavior to trigger on mouse hover rather than on click.
- Moved the modal to the left of the screen.
- Adjusted the modal to be horizontally centered as well.
- Wrap logic in try...catch blocks to handle unexpected errors
- Modal now opens just above the keywords
- Filters display dynamically based on the level
- Added linear gradient to the modal and collapsible elements
- Added Command operations section to the mkdocs.yml file
@jeanlf
Copy link
Member

jeanlf commented Oct 18, 2024

when merging this, we'll have to merge https://github.com/gpac/gpac/tree/buildbot-hintclass

@nlsdvl
Copy link
Collaborator

nlsdvl commented Nov 6, 2024

@jeanlf - I would like to merge this.

I assume the Filter's documentation was generated from that branch : https://github.com/gpac/gpac/tree/buildbot-hintclass

I've opened a PR with the changes in gpac supporting this wiki update: gpac/gpac#3025
We need to merge it before #7 can be automated.

@PierreDillard - thanks for all the work one this and taking into account everybody's feedback.

@jeanlf
Copy link
Member

jeanlf commented Nov 6, 2024

@nlsdvl could you rebase first ? I'll merge everything once done

@jeanlf jeanlf merged commit 8debea4 into gpac:master Nov 7, 2024
@jeanlf
Copy link
Member

jeanlf commented Nov 7, 2024

all merged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants