Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ — Add bigImageUrl option to push command #72

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Sep 4, 2024

Warning: I did not compile to try this as I don’t have a GO dev env, but I think there’s should be no problem.

@ldidry ldidry requested a review from a team as a code owner September 4, 2024 09:12
@ldidry
Copy link
Contributor Author

ldidry commented Sep 4, 2024

I just found that the Dockerfile section of README.md contains instructions to build the application without installing a lot of things to your system, so I was able to build the app.

--bigImageUrl works as expected 🙂

command/push.go Outdated Show resolved Hide resolved
@ldidry ldidry force-pushed the feature/bigimageurl-on-push branch from a3b737d to e0365ff Compare September 5, 2024 11:48
@ldidry ldidry force-pushed the feature/bigimageurl-on-push branch from e0365ff to fd4bd7a Compare September 5, 2024 11:49
@jmattheis jmattheis force-pushed the feature/bigimageurl-on-push branch from 2e19e04 to c08e450 Compare September 5, 2024 18:41
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jmattheis jmattheis merged commit 7d0b8ce into gotify:master Sep 5, 2024
3 of 4 checks passed
@ldidry
Copy link
Contributor Author

ldidry commented Sep 6, 2024

Thanks to you! I don’t know a thing about golang 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants