Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: link gost.so statically to its caller #385

Open
wants to merge 1 commit into
base: openssl_1_1_1
Choose a base branch
from
Open

CMake: link gost.so statically to its caller #385

wants to merge 1 commit into from

Commits on Jan 11, 2022

  1. CMake: link gost.so statically to its caller 

    If any executable loads `gost.so`, the executable already either has
`libcrypto.so` loaded or is statically linked against `libcrypto.a`.
Anyway it already has all libcrypto (and libssl) symbols present.

Without this patch `gost.so` is linked against `libcrypto.so`. As
a result, a diamond dependency is introduced. If `gost.so` is then
loaded by an executable which is statically linked against libcrypto,
`ld` will insist on loading `libcripto.so`, despite the executable
already having all necessary symbols. When the executable is statically
linked, shared objects for libcrypto and libssl are usually not built,
`ld` won't find them, and the caller will crush.

The patch removes this unnecessary link dependency in `gost.so`,
allowing it to be used by executables which are statically linked
against libcrypto.
    Sergei Ianovich committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    be46a9f View commit details
    Browse the repository at this point in the history