This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Light theme #5
Open
Light theme #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Retains the original white background for the popup window, but ensures that foreground font colors are dark. * New file popup.css-light-theme is an identical copy, for backup purposes. * New file popup.css-dark-theme reverses the color scheme, in order to be consistent with the sensibilities of users who prefer a dark theme. * Visibility of the popup's two icons was improved.
|
Is this project abandoned? If so, it's a shame. It was a great idea |
JohnyP36
approved these changes
Jan 26, 2022
@yellowjacketcoder This repo is still public and has not been archived. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Raymond! Thanks for developing this firefox add-on. It wasn't displaying well for me because my configuration is all dark-themed, and the add-on's css wasn't accounting for that possibility. This pull request fixes that, while not disturbing your preference for a light theme within the add-on itself. It also improves the visibility of the popup's two icons.
For people who want a dark-themed popup, I've included an alternate css file, and for those who don't want to open up and alter an xpi tarball, I've set the master branch on my fork to the dark theme. I guess I should add the completed xpi tarball as a file for such people, but I don't yet know the 'best practice' for how that should be done, and anyway you might use the pull request to create a feature to switch themes. If not, you could point your user to this fork so that they can use your add-on with a dark theme.