Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] internal/lib/reflect: convertOp #911

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented Dec 12, 2024

TODO: TestConvert

=> (main.MyBytes).ConvertibleTo([1]uint8) = true, want false
=> (main.MyBytes).ConvertibleTo(main.MyBytesArray) = true, want false
=> (main.MyBytes).ConvertibleTo([2]uint8) = true, want false
=> (main.MyBytes).ConvertibleTo([3]uint8) = true, want false
=> (main.MyBytes).ConvertibleTo(main.MyBytesArray0) = true, want false
=> (main.MyBytes).ConvertibleTo([]uint8) = true, want false
=> ([]uint8).ConvertibleTo(main.MyBytes) = true, want false

@visualfc visualfc marked this pull request as draft December 12, 2024 08:30
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (97a2824) to head (9645d13).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #911   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          22       22           
  Lines        6313     6313           
=======================================
  Hits         6165     6165           
  Misses        128      128           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@visualfc visualfc marked this pull request as ready for review December 12, 2024 12:19
@visualfc visualfc force-pushed the reflect.conv branch 8 times, most recently from 5baa65d to d54b937 Compare December 23, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant