Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] c/neco: init and demo #525

Merged
merged 2 commits into from
Jul 17, 2024
Merged

[wip] c/neco: init and demo #525

merged 2 commits into from
Jul 17, 2024

Conversation

kindy
Copy link
Contributor

@kindy kindy commented Jul 16, 2024

@kindy kindy changed the title c/neco: init and demo [wip] c/neco: init and demo Jul 16, 2024
c/neco/neco.go Outdated Show resolved Hide resolved
c/neco/neco.go Outdated Show resolved Hide resolved
c/neco/neco.go Outdated Show resolved Hide resolved
c/neco/neco.go Outdated Show resolved Hide resolved
c/neco/neco.go Outdated Show resolved Hide resolved
c/neco/neco.go Outdated Show resolved Hide resolved
c/neco/neco.go Outdated Show resolved Hide resolved
@kindy
Copy link
Contributor Author

kindy commented Jul 17, 2024

@xushiwei thanks for the review, I'll fix it latter.

@xushiwei xushiwei merged commit 10b0124 into goplus:main Jul 17, 2024
5 checks passed
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (6e02dac) to head (c0d7ff9).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          19       19           
  Lines        4511     4514    +3     
=======================================
+ Hits         4408     4411    +3     
  Misses         87       87           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kindy kindy deleted the neco branch July 17, 2024 16:11
@xushiwei
Copy link
Member

https://github.com/goplus/llgo/blob/main/c/neco/neco.go#L54

change

type Coro = func(argc c.Int, __llgo_va_list ...any)

to:

type Coro = func(argc c.Int, argv *c.Pointer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants