Merge pull request #295 from visualfc/check_parent

checkParenExpr: check ast.SelectorExpr
goplus · Oct 26, 2023 · 48d24f4 · 48d24f4
2 parents 08fb252 + 461b14d
commit 48d24f4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/ast.go b/ast.go
@@ -871,8 +871,11 @@ func isPointer(typ types.Type) bool {
 }
 
 func checkParenExpr(x ast.Expr) ast.Expr {
-	if _, ok := x.(*ast.CompositeLit); ok {
+	switch v := x.(type) {
+	case *ast.CompositeLit:
 		return &ast.ParenExpr{X: x}
+	case *ast.SelectorExpr:
+		v.X = checkParenExpr(v.X)
 	}
 	return x
 }

diff --git a/builtin_test.go b/builtin_test.go
@@ -601,6 +601,10 @@ func TestCheckParenExpr(t *testing.T) {
 	if _, ok := x.(*ast.ParenExpr); !ok {
 		t.Fatal("TestCheckParenExpr failed:", x)
 	}
+	x = checkParenExpr(&ast.SelectorExpr{X: &ast.CompositeLit{}, Sel: ast.NewIdent("sel")})
+	if _, ok := x.(*ast.SelectorExpr).X.(*ast.ParenExpr); !ok {
+		t.Fatal("TestCheckParenExpr failed:", x)
+	}
 }
 
 func TestNoFuncName(t *testing.T) {