Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support for generic REST client #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtopjian
Copy link
Contributor

This commit adds support for a generic REST actions. These actions allow
direct REST communication while still leveraging some of the core
Gophercloud client features.

For #56

@jtopjian
Copy link
Contributor Author

@j-griffith As discussed a few weeks back, here's a first attempt at a "dummy" client. It's able to leverage existing Provider and Service clients, so things like authentication and core HTTP calls are automatically handled. Technically low-level calls are already possible in Gophercloud, but there's a good amount of work involved, especially if you're making multiple calls, so I tried to strike a balance between the core calls and the per-package functionality.

If you can, at your convenience, let me know what you think or if you see any issues.

@jtopjian
Copy link
Contributor Author

Just noticed I can easily add support for URL/query params, too. I'll loop back to this later today.

@j-griffith
Copy link

Awesome! I'll try and look at it ASAP

This commit adds support for a generic REST actions. These actions allow
direct REST communication while still leveraging some of the core
Gophercloud client features.
Copy link

@j-griffith j-griffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass this look great Joe! I'm going to work on loading it up and trying to implement my own little functional test with some V3.X stuff. I don't want to hold you up because in terms of "looking" at the code it looks great. Just want to make sure things work the way I think they do and make sure I can figure out how to actually write an impl with it. Thanks for hanging in there on this topic and putting this together!

@jtopjian
Copy link
Contributor Author

@j-griffith All sounds good. I'm not in a rush to merge this, so definitely take your time. I'd rather wait a while to hear feedback from yourself or anyone else who notices this PR open :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants