Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terraform]: allow to override service type #229

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Sep 26, 2024

Resolves #228

@kayrus kayrus requested a review from a team September 26, 2024 15:35
@kayrus kayrus force-pushed the service-type-override branch from 3225a14 to 397edf3 Compare September 26, 2024 15:38
@kayrus kayrus force-pushed the service-type-override branch from 397edf3 to ccd1c51 Compare September 26, 2024 15:44
@kayrus
Copy link
Contributor Author

kayrus commented Sep 26, 2024

cc @nikParasyr

@kayrus
Copy link
Contributor Author

kayrus commented Oct 7, 2024

@pierreprinetti @mandre @EmilienM kindly ping

Copy link
Contributor

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we even have a Terraform directory in utils? What is its purpose?

I have nothing against merging this, but I think we should have a migration plan for moving this code to the Terraform provider, if it's needed there

@pierreprinetti pierreprinetti merged commit 46e6234 into gophercloud:master Oct 8, 2024
1 check passed
@kayrus kayrus deleted the service-type-override branch October 8, 2024 10:43
@kayrus
Copy link
Contributor Author

kayrus commented Oct 8, 2024

Why do we even have a Terraform directory in utils? What is its purpose?

initially this was in the openstack terraform project, but this code is used in other terraform related projects that use non-vanilla openstack services. at some point we decided to move it into the gophercloud/utils to reduce the dependency tree.

@pierreprinetti
Copy link
Contributor

Do you think that having all Gophercloud functions accept ServiceClient as an interface (as proposed here) would solve this use-case?

@kayrus
Copy link
Contributor Author

kayrus commented Oct 8, 2024

In theory yes, but the code base should contain some extra logic. Anyway, I don't think that terraform helper code will be rewritten after introducing the client interface.

@pierreprinetti
Copy link
Contributor

I don't think that terraform helper code will be rewritten after introducing the client interface

Indeed, that's fair. I'll keep my spring-cleaning instincts under control for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform: add an ability to override endpoint service name
2 participants